Bump repos #1807
Closed
Bump repos #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Sep 11, 2023
| @@ -284,7 +284,7 @@ jobs: | |||
| run: echo ${{ secrets.QUAY_PASSWORD }} | docker login -u ${{ secrets.QUAY_USERNAME }} --password-stdin quay.io | |||
| - name: Build 🔧 | |||
| run: | | |||
| earthly +all -VARIANT=standard -K3S_VERSION=${{ matrix.k3s_version }} -FLAVOR=${{ matrix.flavor }} | |||
| earthly +all -VARIANT=standard -K3S_VERSION="${{ matrix.k3s_version }}" -FLAVOR=${{ matrix.flavor }} | |||
There was a problem hiding this comment.
Locally when building the image, it was failing to find the package and it worked when I added quotes (there is a + symbol in the version). But I tend to think it was something irrelevant (earthly caches?). Not sure if the quotes are needed.
Itxaka
approved these changes
Sep 11, 2023
|
Can this wait so we merge the other updated package for autoreset fix? :) |
Merged
|
Closing in favor of this: #1808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes k3s not starting on alpine
because of the missing
/etc/rancher/k3sdirectory.Fix from here: kairos-io/packages@96c44ab